fix(spans): Normalize segment span ID #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will follow-up in #3535. |
iker-barriocanal
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpanIdis represented as a string internally, so if we construct it without going throughAnnotated::from_value, lowercase span IDs and uppercase span IDs will be treated as different. This is problematic inset_segment_attributes, which compares the span's ID to its segment ID.We should probably represent
SpanIdas[u8; 8], or at least go throughAnnotated::from_valuefor all Otel types, but this PR should do as a quick fix.#skip-changelog